Fix for unsafe_any_cast #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathworks Inc <Roy.Lurie@mathworks.com>
ksubramz
reviewed
Mar 29, 2017
| @@ -29,6 +29,14 @@ | |||
|
|
|||
| using namespace cppmicroservices; | |||
|
|
|||
| template <typename T> | |||
| void TestUnsafeAnyCast(Any& anyObj, T val) | |||
| { | |||
There was a problem hiding this comment.
Maybe assign the unsafe cast to a local ptr?
T* ptr = unsafe_any_cast<T>(&anyObj);
US_TEST_CONDITION(ptr, "unsafe_any_cast");and similarly for other 2 US_TEST_CONDITIONs
jeffdiclemente
approved these changes
Mar 31, 2017
Signed-off-by: Mathworks Inc <Roy.Lurie@mathworks.com>
saschazelzer
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathworks Inc Roy.Lurie@mathworks.com