New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204a unicode filepath support #245

Merged
merged 7 commits into from Oct 27, 2017

Conversation

Projects
None yet
4 participants
@karthikreddy09
Contributor

karthikreddy09 commented Oct 13, 2017

fixes #204

This PR is a continuation of #207
The original PR will be discarded once this one is merged in.

karthikreddy09 added some commits Oct 12, 2017

Unicode support for bundle paths
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Resolve merge conflicts

Signed-off-by: The Mathworks Inc  <Roy.Lurie@mathworks.com>
Fix merge conflicts after rebase
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Added patch file for miniz changes
Signed-off-by: The Mathworks Inc < Roy.Lurie@matheowks.com>
Appveyor YML change to temporarily ignore MinGW failures
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fix Spacing
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 14, 2017

Codecov Report

Merging #245 into development will increase coverage by 4.47%.
The diff coverage is 76.92%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #245      +/-   ##
===============================================
+ Coverage        77.66%   82.14%   +4.47%     
===============================================
  Files              119      119              
  Lines             7962     8120     +158     
===============================================
+ Hits              6184     6670     +486     
+ Misses            1778     1450     -328
Impacted Files Coverage Δ
util/include/cppmicroservices/util/String.h 100% <ø> (ø) ⬆️
framework/src/bundle/CoreBundleContext.cpp 93.51% <ø> (ø) ⬆️
framework/include/cppmicroservices/BundleContext.h 98.03% <ø> (+0.08%) ⬆️
util/src/Error.cpp 65.21% <ø> (ø) ⬆️
framework/src/bundle/BundleResourceContainer.cpp 95.41% <100%> (ø) ⬆️
framework/src/util/Utils.cpp 62.76% <100%> (ø) ⬆️
util/src/FileSystem.cpp 95.83% <100%> (+0.08%) ⬆️
framework/src/util/SharedLibrary.cpp 91.03% <100%> (+0.06%) ⬆️
framework/src/bundle/BundleUtils.cpp 90.32% <40%> (-9.68%) ⬇️
framework/include/cppmicroservices/ServiceEvent.h 80% <0%> (-20%) ⬇️
... and 13 more

codecov-io commented Oct 14, 2017

Codecov Report

Merging #245 into development will increase coverage by 4.47%.
The diff coverage is 76.92%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #245      +/-   ##
===============================================
+ Coverage        77.66%   82.14%   +4.47%     
===============================================
  Files              119      119              
  Lines             7962     8120     +158     
===============================================
+ Hits              6184     6670     +486     
+ Misses            1778     1450     -328
Impacted Files Coverage Δ
util/include/cppmicroservices/util/String.h 100% <ø> (ø) ⬆️
framework/src/bundle/CoreBundleContext.cpp 93.51% <ø> (ø) ⬆️
framework/include/cppmicroservices/BundleContext.h 98.03% <ø> (+0.08%) ⬆️
util/src/Error.cpp 65.21% <ø> (ø) ⬆️
framework/src/bundle/BundleResourceContainer.cpp 95.41% <100%> (ø) ⬆️
framework/src/util/Utils.cpp 62.76% <100%> (ø) ⬆️
util/src/FileSystem.cpp 95.83% <100%> (+0.08%) ⬆️
framework/src/util/SharedLibrary.cpp 91.03% <100%> (+0.06%) ⬆️
framework/src/bundle/BundleUtils.cpp 90.32% <40%> (-9.68%) ⬇️
framework/include/cppmicroservices/ServiceEvent.h 80% <0%> (-20%) ⬇️
... and 13 more
Show outdated Hide outdated framework/test/driver/BundleTest.cpp Outdated
# Add preprocessor macro to indicate C++11 unicode literal support
#-----------------------------------------------------------------------------
target_compile_definitions(${_test_driver} PUBLIC

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Oct 16, 2017

Contributor

Question: Is C++11 unicode literal support in all the minimum compiler versions CppMicroServices supports? Is a language feature check in a top level CMakeLists.txt file required?

@jeffdiclemente

jeffdiclemente Oct 16, 2017

Contributor

Question: Is C++11 unicode literal support in all the minimum compiler versions CppMicroServices supports? Is a language feature check in a top level CMakeLists.txt file required?

This comment has been minimized.

@karthikreddy09

karthikreddy09 Oct 24, 2017

Contributor

It's not supported in VS2013. Whats the value of adding the check in a top-level file as opposed to here?

@karthikreddy09

karthikreddy09 Oct 24, 2017

Contributor

It's not supported in VS2013. Whats the value of adding the check in a top-level file as opposed to here?

This comment has been minimized.

@karthikreddy09

karthikreddy09 Oct 24, 2017

Contributor

had an offline conversation with Jeff to clarify what is done here.

@karthikreddy09

karthikreddy09 Oct 24, 2017

Contributor

had an offline conversation with Jeff to clarify what is done here.

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Oct 24, 2017

Contributor

there's no value. I misunderstood how unicode literal support detection worked here. This looks fine to me.

@jeffdiclemente

jeffdiclemente Oct 24, 2017

Contributor

there's no value. I misunderstood how unicode literal support detection worked here. This looks fine to me.

#include <stringapiset.h>
#include <wchar.h>
// return NULL if inStr is NULL or if the conversion failed

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Oct 16, 2017

Contributor

a note about who is responsible for de-allocating the memory returned by this function is important.

@jeffdiclemente

jeffdiclemente Oct 16, 2017

Contributor

a note about who is responsible for de-allocating the memory returned by this function is important.

@@ -0,0 +1,57 @@
#include <cppmicroservices/GlobalConfig.h>

This comment has been minimized.

@ksubramz

ksubramz Oct 20, 2017

Contributor

Missing Copyright and License header

@ksubramz

ksubramz Oct 20, 2017

Contributor

Missing Copyright and License header

Changes based on feedback
1. Added copyright in String.cpp
2. Added a comment about de-allocating returned string in miniz.c
3. Changed test point to use US_TEST_FAILED macro

Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fixed a typo
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>

@karthikreddy09 karthikreddy09 merged commit 1b4ea39 into development Oct 27, 2017

3 of 6 checks passed

continuous-integration/appveyor/branch AppVeyor build cancelled
Details
continuous-integration/appveyor/pr AppVeyor build cancelled
Details
codecov/patch 76.92% of diff hit (target 77.66%)
Details
codecov/project 82.14% (+4.47%) compared to a9424e5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@karthikreddy09 karthikreddy09 deleted the 204a-unicode-filepath-support branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment