204a unicode filepath support #245
Conversation
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com> Resolve merge conflicts Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Signed-off-by: The Mathworks Inc < Roy.Lurie@matheowks.com>
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Codecov Report
@@ Coverage Diff @@
## development #245 +/- ##
===============================================
+ Coverage 77.66% 82.14% +4.47%
===============================================
Files 119 119
Lines 7962 8120 +158
===============================================
+ Hits 6184 6670 +486
+ Misses 1778 1450 -328
|
framework/test/driver/BundleTest.cpp
Outdated
| US_TEST_CONDITION(false, "TestUnicodePaths failed with unknown exception"); | ||
| } | ||
| f.Stop(); | ||
| f.WaitForStop(std::chrono::milliseconds::zero()); |
There was a problem hiding this comment.
I'm assuming the goal is to stop the framework if an exception is thrown, which is why US_TEST_CONDITION(false, ...); was used instead of US_TEST_FAILED. If this is the case, I'd suggest using RAII so that f.Stop(); and f.WaitForStop(std::chrono::milliseconds::zero()); are called when this function returns or throws. This allows you to use US_TEST_FAILED effectively.
| # Add preprocessor macro to indicate C++11 unicode literal support | ||
| #----------------------------------------------------------------------------- | ||
|
|
||
| target_compile_definitions(${_test_driver} PUBLIC |
There was a problem hiding this comment.
Question: Is C++11 unicode literal support in all the minimum compiler versions CppMicroServices supports? Is a language feature check in a top level CMakeLists.txt file required?
There was a problem hiding this comment.
It's not supported in VS2013. Whats the value of adding the check in a top-level file as opposed to here?
There was a problem hiding this comment.
had an offline conversation with Jeff to clarify what is done here.
There was a problem hiding this comment.
there's no value. I misunderstood how unicode literal support detection worked here. This looks fine to me.
| #include <stringapiset.h> | ||
| #include <wchar.h> | ||
|
|
||
| // return NULL if inStr is NULL or if the conversion failed |
There was a problem hiding this comment.
a note about who is responsible for de-allocating the memory returned by this function is important.
| @@ -0,0 +1,57 @@ | |||
| #include <cppmicroservices/GlobalConfig.h> | |||
There was a problem hiding this comment.
Missing Copyright and License header
1. Added copyright in String.cpp 2. Added a comment about de-allocating returned string in miniz.c 3. Changed test point to use US_TEST_FAILED macro Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
fixes #204
This PR is a continuation of #207
The original PR will be discarded once this one is merged in.