New install api #481
Merged
New install api #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow for users to implement things such as manifest caching.
carneyweb
assigned saschazelzer, carneyweb, jeffdiclemente and kevinleeMW and unassigned saschazelzer, carneyweb, jeffdiclemente and kevinleeMW
jeffdiclemente
requested changes
Jun 30, 2020
jeffdiclemente
requested changes
Jul 13, 2020
|
Done. |
jeffdiclemente
requested changes
Jul 15, 2020
kevinleeMW
reviewed
Jul 15, 2020
Better description of InstallBundles restored InitialBundleMapCleanup
jeffdiclemente
requested changes
Jul 16, 2020
jeffdiclemente
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the changes to support the addition of a new BundleContext::InstallBundles API. It also includes some changes to remove extraneous output to stdout. Please let me know of any code changes that are needed, questions that you have, or any other issues. There is an accompanying RFC here: https://github.com/CppMicroServices/rfcs/blob/master/text/0006-BundleContext-Install-API.md. I forgot to branch before writing it. Sorry about that. Please review this as well. If there are changes requested (as I'm sure there will be) I'll make them on a separate branch before issuing a pull request with them.
Thanks everyone!