Integrate dynamic ds #482
Merged
Integrate dynamic ds #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test cases fix 0..1 cardinality bug
Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
Implement operator<< to resolve valgrind warnings about un-initialized data due to the compiler padding the structs used for parameterized tests. Fix VS 2015 compiler error: error C2440: 'initializing': cannot convert from 'initializer list' to 'cppmicroservices::scrimpl::RefChangeNotification'
Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
jeffdiclemente
requested review from
carneyweb,
kevinleeMW,
saschazelzer and
a team
|
@CppMicroServices/developers see https://github.com/CppMicroServices/rfcs/blob/master/text/0003-declarative-services.md#-bind--unbind-callbacks- for a description of the bind/unbind callbacks and https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#d0e37698 for a table describing the rules for re-binding to a better target service |
kevinleeMW
reviewed
Jul 15, 2020
compendium/DeclarativeServices/test/TestReferenceManagerImpl.cpp
Outdated
Show resolved
Hide resolved
compendium/DeclarativeServices/src/manager/BindingPolicyDynamicReluctant.cpp
Outdated
Show resolved
Hide resolved
compendium/DeclarativeServices/src/manager/BindingPolicyStaticGreedy.cpp
Outdated
Show resolved
Hide resolved
compendium/DeclarativeServices/src/manager/BindingPolicyStaticGreedy.cpp
Outdated
Show resolved
Hide resolved
jeffdiclemente
commented
Jul 15, 2020
compendium/DeclarativeServices/src/manager/ReferenceManagerImpl.hpp
Outdated
Show resolved
Hide resolved
Signed-off by: The MathWorks, Inc. <jdicleme@mathworks.com>
carneyweb
approved these changes
Jul 16, 2020
compendium/DeclarativeServices/src/manager/ComponentConfigurationImpl.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support dynamic rebinding of service references for 0..1 and 1..1 cardinality (mandatory unary and optional unary)