Anymap erase and compare #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carneyweb
requested review from
aadityap-mathworks,
jeffdiclemente and
kevinleeMW
Codecov Report
@@ Coverage Diff @@
## development #540 +/- ##
===============================================
- Coverage 89.96% 87.35% -2.62%
===============================================
Files 234 82 -152
Lines 9458 4506 -4952
===============================================
- Hits 8509 3936 -4573
+ Misses 949 570 -379
|
It turns out that you have to have a return statement that matches the return type even if the function is never called.
pelliott-mathworks
approved these changes
Apr 5, 2021
achristoforides
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementations of AnyMap::erase(), AnyMap::operator==(), and Any::operator==(). The implementation of Any::operator==() behaves slightly differently than the standard interface: If one of the operator==() operands contains a value whose type does not have an operator==() implementation available, the comparison fails instead of failing to compile. This is because of the implementation of Any::Holder::operator==() which fails to compile if ValueType does not support operator==(), which would disallow storing anything in an Any container that does not provide the equality operator.