New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ServiceTracker race #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race occurs when a customizer is still running and the ServiceTracker object is in the process of being destroyed. Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
jeffdiclemente
requested review from
saschazelzer,
carneyweb,
kevinleeMW,
achristoforides and
pelliott-mathworks
April 30, 2021 19:23
Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
pelliott-mathworks
requested changes
May 3, 2021
achristoforides
approved these changes
May 3, 2021
Codecov Report
@@ Coverage Diff @@
## development #558 +/- ##
===============================================
+ Coverage 89.79% 90.20% +0.40%
===============================================
Files 234 234
Lines 9480 9606 +126
===============================================
+ Hits 8513 8665 +152
+ Misses 967 941 -26
|
jeffdiclemente
commented
May 4, 2021
Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
pelliott-mathworks
approved these changes
May 5, 2021
carneyweb
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race occurs when a customizer is still running and the ServiceTracker object is in the process of being destroyed.
The fix is to have
ServiceTracker::Close
unregister its service listener and then wait for any existing service events to finish processing before cleaning up and calling untrack.Signed-off-by: The MathWorks, Inc. jdicleme@mathworks.com