Fix check-then-act race in GetServiceFromFactory #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
achristoforides
requested review from
carneyweb,
jeffdiclemente and
pelliott-mathworks
Codecov Report
@@ Coverage Diff @@
## development #664 +/- ##
===============================================
- Coverage 90.49% 90.46% -0.03%
===============================================
Files 249 248 -1
Lines 13483 13509 +26
===============================================
+ Hits 12201 12221 +20
- Misses 1282 1288 +6
|
jeffdiclemente
requested changes
May 11, 2022
pelliott-mathworks
approved these changes
May 11, 2022
jeffdiclemente
approved these changes
May 11, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Oct 5, 2022
* Added test case Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Fix check-then-act race for GetServiceFromFactory Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Fixed test names and cleaned up tests Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * More cleanup * Made changes requested by reviewers
jeffdiclemente
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Added test case Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Fix check-then-act race for GetServiceFromFactory Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Fixed test names and cleaned up tests Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * More cleanup * Made changes requested by reviewers Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: The MathWorks, Inc. alchrist@mathworks.com