Fix bug in FindResources() for data-only bundles #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
achristoforides
requested review from
carneyweb,
jeffdiclemente and
pelliott-mathworks
Codecov Report
@@ Coverage Diff @@
## development #667 +/- ##
===============================================
+ Coverage 90.49% 90.50% +0.01%
===============================================
Files 249 248 -1
Lines 13483 13477 -6
===============================================
- Hits 12201 12198 -3
+ Misses 1282 1279 -3
|
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
approved these changes
May 11, 2022
| @@ -265,11 +260,17 @@ bool BundleResourceContainer::Matches(const std::string& name, | |||
| return true; | |||
| } | |||
|
|
|||
| void BundleResourceContainer::OpenContainer() | |||
| void BundleResourceContainer::OpenContainer() const | |||
There was a problem hiding this comment.
this no longer only opens the container. I suggest a method name change to describe the intent. suggestion: OpenAndInitializeContainer
pelliott-mathworks
approved these changes
May 11, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Oct 5, 2022
* Fixed bug in FindResources() for data-only bundles Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Marked bundleManifest as UNUSED in non-threaded env Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Made changes requested by reviewers
jeffdiclemente
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Fixed bug in FindResources() for data-only bundles Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Marked bundleManifest as UNUSED in non-threaded env Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Made changes requested by reviewers Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundle is installed with the optional manifest argument, the bundle isn't fopen'd automatically. In the case of data-only bundles, it is never fopen'd and the BundleResourceContainer is never initialized.
A call to FindResources() on a data-only bundle who was installed via
InstallBundles()with the optional manifest will result in 0 resources always being returned.Signed-off-by: The MathWorks, Inc. alchrist@mathworks.com