Fix inheritance for ComponentException #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not inheriting through public inheritance means that this exception type can't be caught by the std::exception nor std::runtime_error types in a catch. Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
Codecov Report
@@ Coverage Diff @@
## development #676 +/- ##
===============================================
- Coverage 90.42% 90.32% -0.10%
===============================================
Files 249 230 -19
Lines 13532 12465 -1067
===============================================
- Hits 12236 11259 -977
+ Misses 1296 1206 -90
|
achristoforides
approved these changes
May 24, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Oct 17, 2022
Not inheriting through public inheritance means that this exception type can't be caught by the std::exception nor std::runtime_error types in a catch. Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com> Co-authored-by: Jeff <DiClemente>
jeffdiclemente
added a commit
that referenced
this pull request
Oct 18, 2022
Not inheriting through public inheritance means that this exception type can't be caught by the std::exception nor std::runtime_error types in a catch. Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com> Co-authored-by: Jeff <DiClemente> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not inheriting through public inheritance means that this exception type can't be caught by the
std::exceptionnorstd::runtime_errortypes in a catch.Signed-off-by: The MathWorks, Inc. jdicleme@mathworks.com