702 ServiceTracker GetTrackingCount() when opened and then closed #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forked repository
Update CXX_STANDARD to 17 for doc
shane-riley
changed the title
Codecov Report
@@ Coverage Diff @@
## development #714 +/- ##
===============================================
- Coverage 89.86% 89.80% -0.07%
===============================================
Files 230 231 +1
Lines 13639 13823 +184
===============================================
+ Hits 12257 12414 +157
- Misses 1382 1409 +27
|
jeffdiclemente
requested changes
Aug 12, 2022
achristoforides
requested review from
achristoforides,
jeffdiclemente,
carneyweb and
pelliott-mathworks
|
The BundleTracker PR has been updated to match the resolution to 702 in both implementation and in behavior. |
pelliott-mathworks
approved these changes
Aug 15, 2022
jeffdiclemente
approved these changes
Sep 7, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Feb 8, 2023
…pMicroServices#714) * Update CXX_STANDARD to 17 for doc * TrackingCount=-1 when ServiceTracker is closed * Add branch to workflow * Remove branch from workflows * ServiceTracker grab lock only once * Update ServiceTracker.tpp * Update ServiceTracker.tpp Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> Co-authored-by: shane-riley (The Mathworks Inc.) <sriley@mathworks.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com>
jeffdiclemente
added a commit
that referenced
this pull request
Feb 8, 2023
…) (#800) * Update CXX_STANDARD to 17 for doc * TrackingCount=-1 when ServiceTracker is closed * Add branch to workflow * Remove branch from workflows * ServiceTracker grab lock only once * Update ServiceTracker.tpp * Update ServiceTracker.tpp Co-authored-by: Shane Riley <52603694+shane-riley@users.noreply.github.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> Co-authored-by: shane-riley (The Mathworks Inc.) <sriley@mathworks.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the ServiceTracker::GetTrackingCount() method returns -1 if the tracker has been opened and then closed.