701 - Fix warning "Use of BITWISE AND to check if a flag is set" (#849) #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervices#849) Signed-off-by: Tahar Touati <touati.thr@gmail.com>
jeffdiclemente
approved these changes
Aug 7, 2023
jeffdiclemente
merged commit d179b77
into
CppMicroServices:c++14-compliant
37 of 39 checks passed
tcormackMW
added a commit
that referenced
this pull request
Oct 27, 2023
* Fix race with DS service object construction (#801) - C++14 variant (#828) * Fix race with DS service object construction A race occurs when DS is constructing a service object with injectable mandatory service dependencies whereby any bound service dependencies could no longer be available because another thread unregistered any of the bound service dependencies. Given that a ComponentContext is constructed only after all the service dependencies has been satisfied, if during ComponetContext construction any of the bound service dependencies are no nullptrs then throw and fail to construct the service object. This fixes a failure mode where a service constructor can be called with a nullptr service object when the service dependency is defined as mandatory and injection is true. Also noticed that one of the test bundle project was exceeding the path limit on Windows, so shortened the project name to mitigate that problem. * Add more tests Added more tests and fixed up some error messaging --------- Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> * Make a small performance improvement (#808) (#830) stop copying the std::pair in the range-based for. This helps improve the speed of RegisterService Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> * 701 - prepare v3.6.2 release (#831) * Remove jsoncpp from framework build to get up-to-date with #773 jsoncpp itself was already upgraded in v3.6.1. Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> * Only run these tests if threading support is enabled. (#669) Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Rerun clang-format to match v3.7.5 Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> * Update Changelog and versions to match v3.7.5 content Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> --------- Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> * Fix undefined behavior in LDAPExpr::Trim (#835) (#836) if there is no space in the string on the second str.erase, calling str.find_last_not_of() returns std::string::npos. Trying to add 1 to npos leads to undefined behavior reported by UBSAN. Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> * Nested ldap queries (#794) (#886) Added the capability to do ldap queries with nested keys. Queries are first checked against the compound key and if a value is found it is returned. If a value is not found, the key is split into segments on the "." character and then the AnyMap is "walked down" to look for a path to the value in sub-maps addressed by the segments of the key. So, if the value of the key "a.b.c" is queried, 1. Split the key into ["a","b","c"] 2. Check the top level map for a sub-map at key "a". If one is found, look in that map for a key "b" with a sub-map, and in that sub-map for a value with key "c". If found, return it. 3. If the top level map does NOT contain a key "a", look for a sub-map at key "a.b". If one is found, look in that sub-map for a value with a key of "c". If one is found, return it. 4. continue this algorithm down as many levels as there are segments until either the value for the last segment is found (in which case it is returned), or one is not found, in which case the lookup fails. Additional changes to cherry-picked commit: * convert from C++-17 to C++-14 with Abseil (include more parts of Abseil) Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> * Add benchmark test infrastructure to DS (#813) (#887) * Added benchmark suite for DS - Added benchmark test for GetService for service provided by DS * Removed unnecessary lines from CMakeLists.txt for DS benchmark tests * Trying again * Refactored DS test directory to mimic 'framework' test structure * Fixed shadowed function * Actually fix the function shadowing this time? * Removed unnecessary bundles/link-time deps * Updated CHANGELOG.rst --------- Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> Co-authored-by: alchrist <alchrist@mathworks.com> * Updated MSVC Analysis to 0.1.1 and checkout to v3 (#824) (#888) Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> * Upgrade Build: Add Ubuntu 22.04, remove Ubuntu 18.04 (#810) (#889) Fixes #758 Co-authored-by: Shivam Negi <shivamnegi2019@gmail.com> * Automate Performance Testing and Deploy Results (#829) (#890) * Create performance_windows.yml Adding new workflow for running performance tests * Using personal token * Revert "Using personal token" This reverts commit d672a80. * Uploading results to fork * removing https * Changing ph branch * Trying to deploy on another branch * Commit results to gh-pages branch * Added Performance Badge * Added target for performance badge * Update performance_windows.yml * Removing hardcoded paths - Using ENV instead of hard coded build paths - Increased threshold to 20% * Removed Cache operation * Removing performance branch from workflow * Name changed to CppMicroServices Benchmarks --------- Signed-off-by: The MathWorks, Inc. <aadityap@mathworks.com> Co-authored-by: Aaditya Sakharam Patil <36245341+aadityap-mathworks@users.noreply.github.com> Co-authored-by: Aaditya <aadityap@mathworks.com> * Brian decl services (#833) (#891) * Performance micro-optimizations * Fix formatting * More performance improvements * fixed up compilation errors. * deal with unused variable. * restore API ServiceRegistrationBase::SetProperties(ServiceProperties const&) --------- Resolved conflict with previous C++14 changes (absl::string_view). Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Co-authored-by: Brian Weed <brian_weed@yahoo.com> * ComponentManagermemory reallocation bug fix (#834) (#892) * ComponentManagermemory reallocation bug fix The ComponentManagerImpl object contained a shared_ptr to the vector of all ComponentManagerImpl objects. When adding an item to this vector, the resizing of the vector caused a memory allocation error. Fixed by removing the vector from the ComponentManagerImpl object. * Fix for ConfigurationNotifier::CreateFactoryComponent memory allocation error When a ComponentManager is created, it must be added to the managers map in SCRBundleExtension. This is necessary so that when the bundle is stopped, the ComponentManager can be destroyed. The old code was holding a shared_ptr to the managers map in the ComponentManagerImpl object. This caused a memory reallocation error when a ComponentManager was added to the map and the map needed to be resized. This fix adds an AddComponentManager method to the SCRBundleExtension object so that CreateFactoryComponent can add a manager to the managers map when it is created. In order to find the SCRBundleExtension, the map of SCRBundleExtensions was moved out of SCRActivator and into a new class called SCRExtensionRegistry. * Rest of the ConfigurationNotifier fix * Fix errors in minimum gcc build Signed-off by: The MathWorks Inc. < pelliott@mathworks.com> * Responded to code review comments Responded to code review comments. Added tests for SCRBundleExtension and SCRExtensionRegistry. Signed off by - The MathWorks, Inc. <pelliott@mathworks.com> * Update ConfigurationNotifier.cpp Update error message. Signed off by The MathWorks, Inc. <pelliott@mathworks.com> * Update SCRExtensionRegistry.hpp Formatting issue. signed-off by The MathWorks, Inc. <pelliott@mathworks.com> * CreateFactoryComponent changes ConfigurationNotifier::CreateFactoryComponent will log an exception if it can't find the SCRBundleExtension in the ExtensionRegistry instead of throwing a std::runtime_error exception. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Update ConfigurationNotifier.cpp Fixed call to std::exception. Signed-off-by The MathWorks, Inc. <pelliott@mathworks.com> * Update ConfigurationNotifier.cpp Removed throw in CreateFactoryComponent. Error message is already logged, no throw needed. Signed-off-by - The MathWorks, Inc. <pelliott@mathworks.com> --------- Adapt implementation and test code to C++14: * move initialization statements out of if clause * adapt assignment construction in test code calling deleted move constructor Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Co-authored-by: pelliott-mathworks <67922241+pelliott-mathworks@users.noreply.github.com> * Default any map type (#844) (#893) * Fixed undefined behavior in Any::operator==(value) * Revert "Fixed undefined behavior in Any::operator==(value)" This reverts commit 3066fe1. * Default AnyMap(map_type) constructor to UNORDERED_MAP_CASINSENSITIVE_KEYS Co-authored-by: carneyweb <mike@carneyweb.com> * Remove CoreBundleContext.dataStorage clear (#845) (#894) Fixes #733 Co-authored-by: Shivam Negi <shivamnegi2019@gmail.com> * Removing std::move use with const object [ci skip] (#848) (#895) * Removing std::move use with const [ci skip] * Addressing PR feedback, removing const from complex types and adding std move back [ci skip] --------- Signed-off-by: Tahar Touati <touati.thr@gmail.com> Co-authored-by: thrtouati <124062546+thrtouati@users.noreply.github.com> * Fix warning "Use of BITWISE AND to check if a flag is set" (#849) (#896) Signed-off-by: Tahar Touati <touati.thr@gmail.com> Co-authored-by: Tahar Touati <124062546+thrtouati@users.noreply.github.com> * include cstdint in FileSystem.cpp (#850) (#897) vcpkg installation is failing, with this error: PATH/v3.6.0-e25b133cd3.clean/util/src/FileSystem.cpp:122:3: error: ‘uint32_t’ was not declared in this scope PATH/v3.6.0-e25b133cd3.clean/util/src/FileSystem.cpp:71:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’? Sure enough, when patched with this it will build and install correctly with vcpkg. Other errors are reported but this is the culprit. Co-authored-by: Tristan Ayala <ayalat1@unlv.nevada.edu> * Fixes #840: removes manual reference counting (#841) (#898) * converted registration * compiled, not passeD * fixed weak_ptr error, now leaking mock objects * fixed bug, need to decrement ref count * updats from last week, test cases failing because of out of date expectations * all tests are passing with shared and weak pointers to serviceRegistrationBasePrivate * still passing tests, updated comments and cleaned up * updating to share dependents * new issue with dying service * added coreInfo, maybe passing * passing tests, removed manual ref counting from referenceBasePrivate, repeated all fast tests to ensure no sporadic failures * updated comments * updates before PR * Removed manual reference counting The manual reference counting in ServiceRegistrationBasePrivate and ServiceReferenceBasePrivate were removed. Additionally, some properties of ServiceRegistrationBasePrivate were offloaded to a new class ServiceRegistrationCoreInfo which both ServiceRegistrationBasePrivate and ServiceReferenceBasePrivate can access allowing ServiceReferenceBasePrivate to give up ownership of ServiceRegistrationBasePrivate. * Removed manual reference counting and merged with upstream (#840) The manual reference counting in ServiceRegistrationBasePrivate and ServiceReferenceBasePrivate were removed. Additionally, some properties of ServiceRegistrationBasePrivate were offloaded to a new class ServiceRegistrationCoreInfo which both ServiceRegistrationBasePrivate and ServiceReferenceBasePrivate can access allowing ServiceReferenceBasePrivate to give up ownership of ServiceRegistrationBasePrivate. * ServiceRegistrationCoreInfo now default destructor * Updated based on Patty's comments #840 * updated ServiceReferenceBase Constructors for clarity with shared_ptrs * removed 'move' from serviceRegistry * attempt at solving mac issue * updates for lock type and removing unneccessary functions from reference * lost lock * changed to custom atomic load * LockSet addition * threading support in LockSet * LockSet not threaded * no names in func dec * Incoorporated Jeff's Comments * Assignment operator didn't fail on my computer, did in github * updated for Jeff's 5/16 comments * clang update * mikes comments and fixes for multithreaded support * remove ifdefs from BundleRegistry, abide by rule of (0,3,5), and add comments --------- adaptations for C++14: * move initialization statements out of if clauses Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * [ci skip] Updated README to reflect correct compiler/OS versions (#862) (#899) [ci skip] Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> * 701 - Fixes #852: adds a [[nodiscard]] to BundleContext::RegisterService (#863) (#900) * Fixes #852: adds a [[nodiscard]] to BundleContext::RegisterService (#863) * noDiscard update first push * Jeff's comments, c++14 in cmakelists for makefile test, comments to reference nodiscard --- Adaptation for C++14: * use [[nodiscard]] only when __has_cpp_attribute is available and __has_cpp_attribute(nodiscard) is valid. Alternatively use [[gnu::warn_unused_result]] if nodiscard is not available, but gnu::warn_unused_result is. * revert default C++ standard in doc/src/CMakeLists.txt back to C++14 Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> * use nodiscard only if compiled in C++17 mode --------- Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix code scanning alerts (#861) (#903) Fixes #860, #859, #858, #857, #856, #855, #853 ----- C++14 adaptations: use ABSL_FALLTHROUGH_INTENDED instead of [[fallthrough]] Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> * Ensure multiple listeners for the same factory PID are honoured by `ConfigurationNotifier::AnyListenersForPid` (#865) (#904) * Ensure multiple listeners for the same PID are honoured * Fix formatting --------- Signed-off-by: Conor Burgess <Burgess.Conor@gmail.com> Co-authored-by: Conor Burgess <Burgess.Conor@gmail.com> Co-authored-by: cburgess <cburgess@mathworks.com> * Code scanning alert fix: Use of a moved from object #864 (#866) (#905) Fixes #864 * tests passing on linux, all files updated * Mike and Toby backat it again * changed second instance of warning? * reverted naming, final submit Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix race condition when concurrently adding to SCRExtensionRegistry (#870) (#906) * Fix race condition when concurrently adding to SCRExtensionRegistry Fixed a race that can happen when multiple threads are trying to add to the extension registry container. Fixed a bug with the tests for SCRExtensionRegsitry class never being compiled and run. Adaptations for C++14: * fixed call of deleted move-constructor in TestSCRExtensionRegistry.cpp Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> * Fix #868: Recoups some of performance losses from PR #841 (#869) (#907) * fixed lockReg shared_ptr * down to 5% increase from original * get logs from github to verify behavior * reverting performance yml and adding move constructor (default) for RegistrationLocks : Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * #Issue873: Redundant calls to .Load() (#874) (#908) * first commit * test Case * revert test * test fix * naming Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fixes #718 (#876) (#909) Signed-off-by: Toby Cormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #489 - Char Const* property (#877) (#910) * Added case for char const* * formatting --------- Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #879 Change TPP extensions (#880) (#911) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Update performance_windows.yml Removing c++14-compliant branch from performance workflow. This keeps the graph clean * Fix #881 (#912) Reformat `.hpp` files with Clang Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #846 (#878) (#919) * firstCommit * events is all wait for false flags * removed txt files * serviceTracker tsan fixes * deleted txt * tsanSupppressions updated for various tests * removed text files * removed test * added comment * updated suppresssions file with commentss * add sleep to stop spin * add unused flag to lock * revert reformat * formatting * formatting * reformat * updating comments * update comment --------- Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #710 ServiceTracker TSAN warnings (#883) (#923) * fixed tracker race * fixing tsanSupp * fixing tsan mistakes * fixed tracker race * tsan_suppresssions mistype * fixed comments * typos Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #872 (#875) Remove Statics in MultipleListenersTest.cpp and ServiceHooksTest.cpp (#924) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Nested ldap queries (#811) (#925) * disable support for nested filtering set -DSUPPORT_NESTED_LOOKUP to re-enable the algorithm. * Added comment describing enabling nested ldap queries. --------- --------- Addpations for C++14: * replaced std::nullopt with absl::nullopt Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> Co-authored-by: carneyweb <mike@carneyweb.com> * 701 - update 3rd party components (Abseil, googletest, spdlog, nowide) (#927) * update absl to Abseil LTS 20230125.3 * update googletest to release 1.14.0 * update spdlog to version 1.12.0 * update boost nowide to latest commit from standalone branch * Remove unused variable to fix compiler warning (#928) Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> * Fix #920 serviceTracker segfault on concurrent `tracker.Close()` and `framework.Stop()` (#922) (#931) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Add condition on development branch (#916) (#933) * Add condition on development branch Signed-off-by: The MathWorks, Inc. aadityap@mathworks.com Signed-off-by: The MathWorks, Inc. aadityap@mathworks.com Co-authored-by: Aaditya Sakharam Patil <36245341+aadityap-mathworks@users.noreply.github.com> Co-authored-by: aadityap <aadityap@mathworks.com> * Fix #926 Custom CppMicroServices Boost Namespace (#929) (#934) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix Redundant Bundle Validation checks (#921) (#935) Signed-off-by: Shivam Negi <snegi@mathworks.com> Co-authored-by: Shivam Negi <shivamnegi2019@gmail.com> * Fix #913 ServiceTracker deadlock (#915) (#936) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Adding support for multiple cardinality for service references. (#871) (#940) * Adding support for multiple cardinality for service references. Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com * Fixing build failures on Linux/Maci platform * Addressing feedbacks: minor code changes + modifications in unitttests. Signed-off-by: The MathWorks, Inc. <mphadnis@mathworks.com> * Modified test point to check for compile time errors. Fixed formatting in test file. Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com * Changes to automate existing ServiceComponent tests using CMake as compile-only tests. Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com * Fixing clang formatting for test files. Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com * Improvising compile time tests based on feedbacks. Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com * Added doxygen comments to new methods in ReferenceManager Signed-off-by: The MathWorks, Inc. mphadnis@mathworks.com --------- Co-authored-by: Monika032 <monikaphadnis24@gmail.com> Co-authored-by: mphadnis <mphadnis@mathworks.com> * 701 - prepare 3.6.3 release (#941) * Update versions * Untabify CMakeLists.txt * Update Changelog for upcoming 3.6.3 release * Fix _ABSL_SRCS/_ABSL_HDRS (erroneously added headers to _SRCS) * Fix #938 Boost namespace Versioning and remove absl dependency (#939) (#944) * Revert "Fix #926 Custom CppMicroServices Boost Namespace (#929)" This reverts commit aab89e3. Remove commit to reset to original boost namespace * Change Cmake Infrastructure to allow custom Boost library use and remove old commit that changed boost namespace * abseil dependency removal * fix double forward -- maybe, this may be slow * references instead of copies * cmake update ----- C++14 adapations: * don't remove abseil as it is used for more than just strcat Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Fix #937 `GetServiceReferences` ordering guarantee (#943) (#946) Signed-off-by: tcormack <tcormack@mathworks.com> Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * CMake Updates for Boost Versioning Fix (#945) (#950) * cmake updates * behavior put in cmake function * usFunctionBoostPath update Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Initializer list support (#942) (#952) Added support for std::initializer_list constructurs Updated tests to use new initializer simplifying the code. Co-authored-by: carneyweb <mike@carneyweb.com> * ServiceComponent build tests cmake configuration (#949) (#953) * use cmake build type * set to debug by default Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> * Update Changelog for upcoming 3.6.3 release (#954) [ci skip] [ci skip] --------- Signed-off-by: Ingmar Sittl <ingmar.sittl@elektrobit.com> Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com> Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Signed-off-by: The MathWorks, Inc. <aadityap@mathworks.com> Signed-off-by: Tahar Touati <touati.thr@gmail.com> Signed-off-by: Ingmar Sittl <Ingmar.Sittl@elektrobit.com> Signed-off-by: Conor Burgess <Burgess.Conor@gmail.com> Signed-off-by: Toby Cormack <tcormack@mathworks.com> Signed-off-by: tcormack <tcormack@mathworks.com> Signed-off-by: The MathWorks, Inc. aadityap@mathworks.com Signed-off-by: Shivam Negi <snegi@mathworks.com> Co-authored-by: Ingmar Sittl <79453136+insi-eb@users.noreply.github.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> Co-authored-by: alchrist <alchrist@mathworks.com> Co-authored-by: Shivam Negi <shivamnegi2019@gmail.com> Co-authored-by: Aaditya Sakharam Patil <36245341+aadityap-mathworks@users.noreply.github.com> Co-authored-by: Aaditya <aadityap@mathworks.com> Co-authored-by: Brian Weed <brian_weed@yahoo.com> Co-authored-by: pelliott-mathworks <67922241+pelliott-mathworks@users.noreply.github.com> Co-authored-by: carneyweb <mike@carneyweb.com> Co-authored-by: thrtouati <124062546+thrtouati@users.noreply.github.com> Co-authored-by: Tristan Ayala <ayalat1@unlv.nevada.edu> Co-authored-by: Conor Burgess <Burgess.Conor@gmail.com> Co-authored-by: cburgess <cburgess@mathworks.com> Co-authored-by: Monika032 <monikaphadnis24@gmail.com> Co-authored-by: mphadnis <mphadnis@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked 8f4432a / #849 without changes.