Fix #678 Detect Circular References #917
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcormackMW
requested review from
carneyweb,
jeffdiclemente,
achristoforides and
pelliott-mathworks
|
NOTE I have made this PR not because it is necessarily at a stage where we are confident that this is the correct approach, more just because I figured it would be helpful for people wanting to make comments on the design who don't want to do so in the RFA. |
ok. In this case, I've marked this PR as a draft to indicate the state of the code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logging capability to track potential circular references that exist between services in DS.