RSC can create hospitals #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd_doc into rsc_create_hospitals
tochman
reviewed
Nov 3, 2018
…urse_and_doc into rsc_create_hospitals
…still failing but looking better
…so refactored the test for the the steps to find hospitals on the hospitals and add the hospital path to the add button with no effect unfortunely
… click on the hospital page and see the form
tochman
reviewed
Nov 4, 2018
…e steps one test falling
…ew js.erb, also refactroed the controller and update the hospital index link
…eature steps to add ajax flow
… added a new step to for the success message
…urse_and_doc into rsc_create_hospitals
RhonGabriel
reviewed
Nov 5, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
reviewed
Nov 6, 2018
tochman
previously requested changes
Nov 6, 2018
…nd_doc into rsc_create_hospitals
angiecstn
dismissed
tochman’s stale review
All comments have been addressed / issues have been solved
RhonGabriel
approved these changes
Nov 6, 2018
Prozak8
approved these changes
Nov 6, 2018
tochman
requested changes
Nov 6, 2018
app/views/hospitals/_index.html.haml
Outdated
| .list-grid | ||
| .list-name | ||
| = f.text_field :name, id: "Name", class: "form-input-field" |
There was a problem hiding this comment.
If .list-grid is supposed to be a wrapper around the link_to, this line needs to be intended
There was a problem hiding this comment.
Sorry, my bad, I mean f.text_field
There was a problem hiding this comment.
.list-grid
.list-name
= f.text_field :name, id: "Name", class: "form-input-field"
There was a problem hiding this comment.
And also, please make sure to use single quotes. Install RuboCop extension and you will be able to format your code and fix details like that with auto format.
app/views/hospitals/_index.html.haml
Outdated
| = f.text_field :name, id: "Name", class: "form-input-field" | ||
| .list-button-area | ||
| = f.submit value: "Add Hospital", class: "button text-center" |
tochman
reviewed
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Link
https://www.pivotaltracker.com/story/show/161589429
Included in PR
Screenshot