Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post job to staffing companies using a webhook #34

Merged
merged 13 commits into from
Nov 15, 2018
Merged

Post job to staffing companies using a webhook #34

merged 13 commits into from
Nov 15, 2018

Conversation

Prozak8
Copy link
Collaborator

@Prozak8 Prozak8 commented Nov 14, 2018 •
edited
Loading

PT Link

https://www.pivotaltracker.com/story/show/161948352

Included in PR

  • Job form now posts a job to staffing company on creation using a webhook
  • Addition of webmock to test environment
  • Rest Client gem added to global
  • Tested in Cucumber using rspec elements

@Prozak8 Prozak8 changed the title Api post Post job to staffing companies using a webhook Nov 14, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 84.184%
Totals Coverage Status
Change from base Build 41: 1.8%
Covered Lines: 165
Relevant Lines: 196
💛 - Coveralls

@Noelryn Noelryn requested review from rupertlion, angiecstn and RhonGabriel and removed request for rupertlion and angiecstn November 14, 2018 17:40
tochman
tochman reviewed Nov 14, 2018
View reviewed changes
features/support/env.rb Outdated Show resolved Hide resolved
features/rsc_can_create_new_job.feature Outdated Show resolved Hide resolved
@Noelryn Noelryn merged commit 59aad24 into CraftAcademy:development Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tochman tochman tochman left review comments

@rupertlion rupertlion Awaiting requested review from rupertlion

@RhonGabriel RhonGabriel Awaiting requested review from RhonGabriel

@angiecstn angiecstn Awaiting requested review from angiecstn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Prozak8 @coveralls @tochman @Noelryn