Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC Can See List of Hospitals #4

Merged
merged 17 commits into from
Nov 2, 2018
Merged

RSC Can See List of Hospitals #4

merged 17 commits into from
Nov 2, 2018

Conversation

angiecstn
Copy link
Collaborator

@angiecstn angiecstn commented Nov 1, 2018 •
edited by Noelryn
Loading

PT Link:

https://www.pivotaltracker.com/story/show/161644372

Included in PR

  • Adding hospital model
  • Adding hospital controller
  • Adding hospital index view
  • Adding feature and step definition for RSC can see list of hospitals
  • Adding factory bot for hospitals
  • Adding styling (and extracting tailwind components)
  • Adding hospitals in seed file

Screenshot

screen shot 2018-11-01 at 14 26 16

@coveralls
Copy link

coveralls commented Nov 1, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 13

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+19.7%) to 51.724%
Totals Coverage Status
Change from base Build 8: 19.7%
Covered Lines: 15
Relevant Lines: 29
💛 - Coveralls

rupertlion
rupertlion reviewed Nov 1, 2018
View reviewed changes
features/step_definitions/hospital_listing_steps.rb Outdated Show resolved Hide resolved
spec/models/hospital_spec.rb Show resolved Hide resolved
features/rsc_can_see_list_of_hospitals.feature Outdated Show resolved Hide resolved
@angiecstn angiecstn changed the title [WIP] RSC Can See List of Hospitals RSC Can See List of Hospitals Nov 1, 2018
@Prozak8 Prozak8 self-requested a review November 1, 2018 15:00
Prozak8
Prozak8 reviewed Nov 1, 2018
View reviewed changes
app/javascript/css/tailwind.scss Show resolved Hide resolved
app/views/hospitals/index.html.haml Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
features/step_definitions/new_object_steps.rb Outdated Show resolved Hide resolved
Prozak8
Prozak8 approved these changes Nov 1, 2018
View reviewed changes
Copy link
Collaborator

@Prozak8 Prozak8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@RhonGabriel RhonGabriel merged commit d7e0a51 into CraftAcademy:development Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnus-thor magnus-thor magnus-thor left review comments

@rupertlion rupertlion rupertlion left review comments

@tochman tochman tochman approved these changes

@Prozak8 Prozak8 Prozak8 approved these changes

@Noelryn Noelryn Noelryn approved these changes

@RhonGabriel RhonGabriel RhonGabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@angiecstn @coveralls @tochman @magnus-thor @rupertlion @Prozak8 @Noelryn @RhonGabriel