Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post code verification #14

Merged
merged 16 commits into from Sep 11, 2019
Merged

Post code verification #14

merged 16 commits into from Sep 11, 2019

Conversation

pedbr
Copy link
Contributor

@pedbr pedbr commented Sep 10, 2019

User Story

As a Client
In order to find suppliers near me,
I would like to be able to provide my location trough postcode/city

Feature description

https://www.pivotaltracker.com/story/show/168251995

Description of PR

  • Build postal code input modal
  • Create request to API to get location from post code
  • Associate location to Service Request

erikwesterberg and others added 16 commits September 10, 2019 14:40
@erikwesterberg
creatas a new component for zip code verification,
cc2292b
@pedbr
merges with upstream
de6c2be
@pedbr
creates feature test
e290254
@erikwesterberg
add visit server on test file , aslo adds id do button
658d92c
@pedbr
fixes location modal with input field and buttons
20f4b96
@erikwesterberg
taking help of useState to make a get req for the city trough zipcode
67154c4
@pedbr
adds onchange function to input form, fixes axios post request
b442792
@erikwesterberg
continious building on function to retrive city
f35606e
@pedbr
fixes post req url, fixes value sent has param, removes console logs …
9141aaf 
…and debuggers
@pedbr
adds sad paths on feature tests
5818fa5
@pedbr
adds type=number on input field to not accept characters, also adds r…
b8bbe97 
…egex in case caracters are writen axios call is not made
@pedbr
adds error rendering, adds continue button only when location fetched
ef4a9c8
@pedbr
creates location reducer to have locations as app state
8767e86
@erikwesterberg
creates a action in redux
7da10ae
@pedbr
imports redux to city fetcher component, adds dispatch to successful …
6454046 
…request
@pedbr
fixes dipatch action, now location being updated on location state
10a81f5
@pedbr pedbr changed the title [WIP] Post code verification Post code verification Sep 11, 2019
tochman
tochman approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@tochman tochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job. 👊

@tochman tochman merged commit 09ba20a into CraftAcademy:development Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tochman tochman tochman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pedbr @tochman @erikwesterberg