Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can login and log out #9

Merged
merged 16 commits into from Feb 1, 2019
Merged

User can login and log out #9

merged 16 commits into from Feb 1, 2019

Conversation

GergKllai1
Copy link
Collaborator

@GergKllai1 GergKllai1 commented Feb 1, 2019 •
edited

PT Link

User can login and log out

User Story

As a user
In order to access the features on the site
I would like to be able to log in and log out

Screenshots

feb-01-2019 10-33-57

Description of PR

  • Adds login form component
  • Sends axios post request to sessions controller
  • Tailors session controller to accept incoming data and send back error response
  • Conditions sessions and authentication links based on whether user is logged in or not
  • Adds basic styling
  • Refactors components into matching folders
  • Refactors feature tests

@GergKllai1 GergKllai1 changed the title [WIP] User can login and log out User can login and log out Feb 1, 2019
HannaSwDn
HannaSwDn reviewed Feb 1, 2019
View reviewed changes
app/controllers/devise/sessions_controller.rb Outdated Show resolved Hide resolved
app/controllers/devise_controller.rb Outdated Show resolved Hide resolved
app/controllers/devise_controller.rb Outdated Show resolved Hide resolved
app/controllers/devise_controller.rb Outdated Show resolved Hide resolved
app/controllers/devise_controller.rb Outdated Show resolved Hide resolved
johannaanden
johannaanden approved these changes Feb 1, 2019
View reviewed changes
Copy link
Collaborator

@johannaanden johannaanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

magnus-thor
magnus-thor approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@magnus-thor magnus-thor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@magnus-thor magnus-thor merged commit 392979a into CraftAcademy:develop Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianaditya kianaditya kianaditya left review comments

@HannaSwDn HannaSwDn HannaSwDn left review comments

@magnus-thor magnus-thor magnus-thor approved these changes

@johannaanden johannaanden johannaanden approved these changes

@schneiderman805 schneiderman805 schneiderman805 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GergKllai1 @kianaditya @magnus-thor @HannaSwDn @johannaanden @schneiderman805