Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach image to profile #2 #54

Merged

Conversation

Siianko
Copy link
Contributor

@Siianko Siianko commented Sep 13, 2018

PT Story

https://www.pivotaltracker.com/story/show/160220309

User story

As an Artist
In order to promote ourself/myself
We/I would like to be able to attach images to our/my profile

Tasks

  • Add image field to the create profile form
  • Add association: User has_many_attached image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1

  • 7 of 13 (53.85%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 88.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/models/performer.rb 7 13 53.85%
Totals Coverage Status
Change from base Build 49: -1.5%
Covered Lines: 272
Relevant Lines: 307

💛 - Coveralls

Copy link
Contributor

@Andycutter Andycutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Andycutter Andycutter merged commit 89231aa into CraftAcademyLabs:development Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants