Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row Element should be directly provided to the onEdit() function option #15

Closed
CraftingGamerTom opened this issue Feb 7, 2021 · 0 comments
Closed

Row Element should be directly provided to the onEdit() function option #15

CraftingGamerTom opened this issue Feb 7, 2021 · 0 comments
Assignees
@CraftingGamerTom
Labels
bug Something isn't working
Milestone
v1.1.0

Comments

@CraftingGamerTom
Copy link
Owner

Users are currently required to access the row element in the following way

onEdit:function($row) {
    console.log("EDITED:", $row[0]);
},

They should be able to access it like

onEdit:function($row) {
    console.log("EDITED:", $row);
},

The issue seems to be how the $row is initialized on line 176 in bstable.js please update any needed locations of the code
@CraftingGamerTom CraftingGamerTom added the bug Something isn't working label Feb 7, 2021
CraftingGamerTom added a commit that referenced this issue Feb 7, 2021
@CraftingGamerTom
Provide element to onEdit rather than jQuery obj
e1fee5b 
#12 #15
@CraftingGamerTom CraftingGamerTom self-assigned this Feb 7, 2021
@CraftingGamerTom CraftingGamerTom added this to the v1.1.0 milestone Feb 7, 2021
@CraftingGamerTom CraftingGamerTom mentioned this issue Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CraftingGamerTom CraftingGamerTom

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@CraftingGamerTom