Properly collect/identify used DWARF entries. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sunfishcode
reviewed
Jul 11, 2019
|
Looks good! |
sunfishcode
pushed a commit
that referenced
this pull request
Jul 17, 2019
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Add ARMv7 as CI test target * Avoid UB in conversions from floating point When truncating floating point values to integer values, we need to avoid undefined behavior if the argument does not fit into the target type which is currently impossible using casts of primitive types. Hence, this reimplements those conversions using arbitrary precision integers and rationals from the num crate.
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Fix wasmi no_std support (bytecodealliance#218) Two issues are fixed: 1. num-bigint 0.2 requires std, and is used to perform float to int conversions since bytecodealliance#186. This patch disables this change in no_std environments. This change can be reverted once num-bigint 0.3 is released, which will support no_std. 2. The `f{32,64}::fract` method is currently not implemented by core, only std. This patch uses the no_std supporting implementation from num-trait's FloatCore trait. * Ensure wasmi builds without std in CI The no-std-check cargo subcommand uses a custom sysroot to prevent the crate from using std while checking a local target. This should help ensure that changes which introduce std dependencies are caught at review time.
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Jan 26, 2024
Align stack handling with other architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch: