Tests for cache system #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrowqa
force-pushed
the
cache-tests
branch
3 times, most recently
from
61570c8
to
4f4a01d
Compare
Merged
mrowqa
force-pushed
the
cache-tests
branch
2 times, most recently
from
b3ff7c2
to
3ce5f16
Compare
sunfishcode
reviewed
Aug 19, 2019
wasmtime-environ/src/cache.rs
Outdated
| } | ||
| } | ||
|
|
||
| // cranelift's types (including SecondaryMap) doesn't implement PartialEq |
There was a problem hiding this comment.
I know I originally suggested using this approach, but I actually think we can go back and implement Eq/PartialEq for SecondaryMap, with the approach of trimming the trailing default-value elements. That should hopefully allow the code here to be much simpler.
There was a problem hiding this comment.
As we discussed, I'll do it as a follow up refactor later, also implementing the serialization for SecondaryMap.
wasmtime-environ/src/cache.rs
Outdated
| } | ||
| } | ||
|
|
||
| // binemit::Reloc doesn't implement PartialEq |
There was a problem hiding this comment.
We should make binemit::Reloc implement PartialEq and Eq.
There was a problem hiding this comment.
Same thing as with SecondaryMap - I'll do it later as follow up refactor.
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Fix wasmi no_std support (bytecodealliance#218) Two issues are fixed: 1. num-bigint 0.2 requires std, and is used to perform float to int conversions since bytecodealliance#186. This patch disables this change in no_std environments. This change can be reverted once num-bigint 0.3 is released, which will support no_std. 2. The `f{32,64}::fract` method is currently not implemented by core, only std. This patch uses the no_std supporting implementation from num-trait's FloatCore trait. * Ensure wasmi builds without std in CI The no-std-check cargo subcommand uses a custom sysroot to prevent the crate from using std while checking a local target. This should help ensure that changes which introduce std dependencies are caught at review time.
mooori
added a commit
to mooori/wasmtime
that referenced
this pull request
Feb 28, 2024
feat: add ISA specific setting `instrument_inst` for zkASM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #223. Draft to avoid merging before #223.