Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare version 1.7.0 #47

Merged
merged 5 commits into from
Aug 8, 2022
Merged

Declare version 1.7.0 #47

merged 5 commits into from
Aug 8, 2022

Conversation

ekamin-hpe
Copy link
Contributor

@ekamin-hpe ekamin-hpe commented Aug 8, 2022

Summary and Scope

  • Declare version 1.7.0 in the change log
  • Fix a bug that was preventing cf-gitea-import from working when the value of CF_IMPORT_GITEA_URL had trailing components, e.g. "https://api-gw-service-nmn.local/vcs", caused by a slightly incorrect use of urljoin.
  • Add an alternate entrypoint that does not wait on the Envoy sidecar proxy to be available, which allows cf-gitea-import to be run directly via podman, if a product install mounts the ansible content to import.
  • This change does not change the default entrypoint and the image continues to work in the "old" way, in which a product-specific image is derived from cf-gitea-import.

Issues and Related PRs

Testing

Tested on:

  • groot

Test description:

  • Built the image.
  • Built a version of sat-cfs-install derived from this image, and used
    a loftsman manifest and helm chart to import a version of SAT
    configuration.
  • Built a version of the product stream with this image, Ran cf-gitea-import
    directly using podman, mounting in a version of SAT configuration
    over /content.

Risks and Mitigations

N/A

Pull Request Checklist

csm-gitflow-merge-back-bot bot and others added 5 commits August 5, 2022 14:53
…650729363

[chore] master -> develop from PR #44 (release/1.6.2)
This commit fixes the use of `urljoin` so that trailing path components
are not stripped off of `gitea_base_url`.

If the second argument to `urljoin()` begins with a `/` character
it is assumed that it begins at the root of the website and trailing
path components are stripped from the base URL (the first argument).
For example, `urljoin('https://foo.com/bar', '/baz') returns:
`'https://foo.com/baz'`.

Additionally, if the first argument to `urljoin()` contains path
components after the domain and does NOT end with a `/` character
(e.g. https://foo.com/bar), the path components are stripped.
For example, `urljoin('https://foo.com/bar', 'baz')` returns
`'https://foo.com/baz'` as well.

This usually isn't encountered because the typical way of using
cf-gitea-import is using `'https://gitea-vcs'` as the value of
`gitea_base_url`.

This commit also removes an unused import of HTTPBasicAuth in `import.py`,
as well as the now-unused import of urljoin.

Finally, add a change log entry.

Test Description:
* Built the image.
* Built a version of sat-cfs-install derived from this image, and used
  a loftsman manifest and helm chart to import a version of SAT
  configuration.
* Built a version of the product stream with this image, Ran cf-gitea-import
  directly using podman, mounting in a version of SAT configuration
  over `/content`.
This commit adds an entrypoint that can be used to run the
cf-gitea-import image directly (e.g. via podman) instead of using
Kubernetes and Helm. The motivation for this is so that products
can mount the configuration in the `/content` directory rather than
create an image based on cf-gitea-import.

Add change log entry.

Test Description:
* Built the image.
* Built a version of sat-cfs-install derived from this image, and used
  a loftsman manifest and helm chart to import a version of SAT
  configuration.
* Built a version of the product stream with this image, then ran
  cf-gitea-import directly using podman, mounting in a version of
  SAT configuration over `/content`.
…port-enhancements

CRAYSAT-1512: cf-gitea-import enhancements
This commit declares a new version of cf-gitea-import in the change log.
A link to the tag is also added at the bottom of the change log as well
as a link to compare the latest version with any unreleased content.
@ekamin-hpe ekamin-hpe requested a review from a team as a code owner August 8, 2022 20:34
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rbak-hpe rbak-hpe merged commit b3a9817 into master Aug 8, 2022
@rbak-hpe rbak-hpe deleted the release/1.7.0 branch August 8, 2022 20:45
csm-gitflow-merge-back-bot bot added a commit that referenced this pull request Aug 8, 2022
…659991580

[chore] master -> develop from PR #47 (release/1.7.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants