-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare version 1.7.0 #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…650729363 [chore] master -> develop from PR #44 (release/1.6.2)
This commit fixes the use of `urljoin` so that trailing path components are not stripped off of `gitea_base_url`. If the second argument to `urljoin()` begins with a `/` character it is assumed that it begins at the root of the website and trailing path components are stripped from the base URL (the first argument). For example, `urljoin('https://foo.com/bar', '/baz') returns: `'https://foo.com/baz'`. Additionally, if the first argument to `urljoin()` contains path components after the domain and does NOT end with a `/` character (e.g. https://foo.com/bar), the path components are stripped. For example, `urljoin('https://foo.com/bar', 'baz')` returns `'https://foo.com/baz'` as well. This usually isn't encountered because the typical way of using cf-gitea-import is using `'https://gitea-vcs'` as the value of `gitea_base_url`. This commit also removes an unused import of HTTPBasicAuth in `import.py`, as well as the now-unused import of urljoin. Finally, add a change log entry. Test Description: * Built the image. * Built a version of sat-cfs-install derived from this image, and used a loftsman manifest and helm chart to import a version of SAT configuration. * Built a version of the product stream with this image, Ran cf-gitea-import directly using podman, mounting in a version of SAT configuration over `/content`.
This commit adds an entrypoint that can be used to run the cf-gitea-import image directly (e.g. via podman) instead of using Kubernetes and Helm. The motivation for this is so that products can mount the configuration in the `/content` directory rather than create an image based on cf-gitea-import. Add change log entry. Test Description: * Built the image. * Built a version of sat-cfs-install derived from this image, and used a loftsman manifest and helm chart to import a version of SAT configuration. * Built a version of the product stream with this image, then ran cf-gitea-import directly using podman, mounting in a version of SAT configuration over `/content`.
…port-enhancements CRAYSAT-1512: cf-gitea-import enhancements
This commit declares a new version of cf-gitea-import in the change log. A link to the tag is also added at the bottom of the change log as well as a link to compare the latest version with any unreleased content.
Kudos, SonarCloud Quality Gate passed!
|
haasken-hpe
approved these changes
Aug 8, 2022
rbak-hpe
approved these changes
Aug 8, 2022
csm-gitflow-merge-back-bot bot
added a commit
that referenced
this pull request
Aug 8, 2022
…659991580 [chore] master -> develop from PR #47 (release/1.7.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
urljoin
.Issues and Related PRs
Testing
Tested on:
Test description:
a loftsman manifest and helm chart to import a version of SAT
configuration.
directly using podman, mounting in a version of SAT configuration
over
/content
.Risks and Mitigations
N/A
Pull Request Checklist