Better error capabilities for Fortran #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billschereriii
added
type: feature
|
PGP token was timing out so I've rerun jobs |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #284 +/- ##
========================================
Coverage 77.93% 77.93%
========================================
Files 57 57
Lines 3666 3666
========================================
Hits 2857 2857
Misses 809 809 |
ashao
requested changes
Dec 5, 2022
There was a problem hiding this comment.
Looks really good and especially like how compact the code was to pass a C-string to a Fortran string. Biggest suggestions (as we talked about):
- Combine the two methods so that we just concatenate the error and the location
- Add new function called
print_last_errorthat writes to aSTDERRby default or optionally a user-specifed unit
ashao
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.