Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc theme and fix doc strings #294

Merged
merged 2 commits into from Jan 25, 2023

Conversation

mellis13
Copy link
Collaborator

This PR updates the documentation theme to sphinx_book_theme to match the SmartSim theme. It also fixes link errors in the changelog and doc string errors in client.py.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #294 (c5ac282) into develop (36c6c26) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #294   +/-   ##
========================================
  Coverage    77.13%   77.13%           
========================================
  Files           66       66           
  Lines         4151     4151           
========================================
  Hits          3202     3202           
  Misses         949      949           
Impacted Files Coverage Δ
src/python/module/smartredis/client.py 95.15% <ø> (ø)

Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing up all the doc strings

@mellis13 mellis13 merged commit 1cac70c into CrayLabs:develop Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants