Downgrade F2018 requirement to F2003 (NVHPC support) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billschereriii
approved these changes
May 26, 2023
|
Approval is conditional of course on test cases passing |
Changing the declaration of arrays from dimension(..) (an F2018 feature) to dimensio(*) seems to preserve the same functionality and enable compilers like Nvidia's which only have support up to F2003 to compile SmartRedis. All tests pass
This reverts commit c6b1694.
ashao
added a commit
to ashao/SmartRedis
that referenced
this pull request
Jul 6, 2023
The Nvidia compilers do not support the assumed rank F2018 feature that we use to minimize the code in the `client` and `dataset`. Using a macro that detects whether the Nvidia compiler is being used, the declaration is instead assumed-size (`dimension(*)`). The macro is required as both gfortran and ifort do not see this use of assumed-size as valid. All tests where library and testers are compiled with Nvidia 22.3.0 have confirmed to pass. Note: support for this should be considered experimental until we add this compiler chain to our nightly builds. [ committed by @ashao ] [ reviewed by @billschereriii ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the assumed rank feature of F2018 used in the Fortran client with assumed
shape arrays. Compilers need only be compliant with the F2003 standard now. While
this means that it is possible to compile SmartRedis with the Nvidia toolchain,
users should consider this only experimental support until we can incorporate
Nvidia compilers into our CI.