Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate lint errors, apply formatters #371

Merged
merged 12 commits into from Jul 12, 2023
Merged

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 6, 2023

  • Mitigate linting/formatting errors that have crept in over time.
  • Add execution of linter to github workflow
  • Apply black formatter
  • Apply isort formatter

Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good. I'd like to get the key parameter for RedisReplyError resolved before approving

Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for your hard work in getting this one through the finish line!

@ankona ankona added area: python Issues related to the Python Client area: CI/CD Issues related to continuous integration and deployment labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #371 (cd2c43d) into develop (ea08165) will decrease coverage by 8.08%.
The diff coverage is 94.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
- Coverage    78.37%   70.30%   -8.08%     
===========================================
  Files           97       97              
  Lines         7067     7072       +5     
===========================================
- Hits          5539     4972     -567     
- Misses        1528     2100     +572     
Impacted Files Coverage Δ
src/python/module/smartredis/dataset.py 100.00% <ø> (ø)
src/python/module/smartredis/error.py 81.81% <ø> (-13.64%) ⬇️
src/python/module/smartredis/logcontext.py 66.66% <0.00%> (-2.57%) ⬇️
src/python/module/smartredis/srobject.py 83.87% <ø> (-0.51%) ⬇️
src/python/module/smartredis/util.py 85.96% <50.00%> (-1.76%) ⬇️
src/python/module/smartredis/__init__.py 100.00% <100.00%> (ø)
src/python/module/smartredis/client.py 95.47% <100.00%> (-0.24%) ⬇️
src/python/module/smartredis/configoptions.py 93.54% <100.00%> (-4.82%) ⬇️
src/python/module/smartredis/dataset_utils.py 97.05% <100.00%> (+0.28%) ⬆️
src/python/module/smartredis/logger.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@ankona ankona merged commit 4787cb5 into CrayLabs:develop Jul 12, 2023
46 checks passed
@ankona ankona deleted the oss339 branch July 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment area: python Issues related to the Python Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants