New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mitigate lint errors, apply formatters #371
Conversation
ankona
commented
Jul 6, 2023
- Mitigate linting/formatting errors that have crept in over time.
- Add execution of linter to github workflow
- Apply black formatter
- Apply isort formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks very good. I'd like to get the key parameter for RedisReplyError resolved before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for your hard work in getting this one through the finish line!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
- Coverage 78.37% 70.30% -8.08%
===========================================
Files 97 97
Lines 7067 7072 +5
===========================================
- Hits 5539 4972 -567
- Misses 1528 2100 +572
|