Expose MINBATCHTIMEOUT parameter in set_model interface #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billschereriii
added
type: feature
Codecov Report
@@ Coverage Diff @@
## develop #406 +/- ##
===========================================
+ Coverage 78.19% 78.38% +0.18%
===========================================
Files 97 97
Lines 7178 7204 +26
===========================================
+ Hits 5613 5647 +34
+ Misses 1565 1557 -8
|
ashao
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks for turning that around so quick! Will definitely lead to easy performance gains.
Only one request from me
- Throw a warning if
MINBATCHSIZE>0andMINBATCHTIMEOUT==0to nudge the user. Something along the lines ofmin_batch_timeout was set with a non-zero min_batch_size. Performance may improve by passing in a small value (~10ms) for min_batch_timeout - Throw an exception if
MINBATCHTIMEOUT>0 and (MINBATCHSIZE==0 or BATCHSIZE==0)with the message thatmin_batch_size and batch_size must be non-zero if min_batch_timeout>0
Add those tests to ensure we're throwing those to test_errors.py.
ashao
approved these changes
Oct 4, 2023
.github/workflows/run_tests.yml
Outdated
| @@ -67,6 +67,13 @@ jobs: | |||
| GCC_V: ${{ matrix.compiler }} # used when the compiler is gcc/gfortran | |||
|
|
|||
| steps: | |||
| # Free up some disk space | |||
| run: | | |||
There was a problem hiding this comment.
Ooof really these are the kind of games that we have to play?Q
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.