Create run settings #110
Merged
Create run settings #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2021 13:13
Experiment.create_run_settings has been implmented which is a factory method for creating run settings types. The run_command default is "auto" which attempts to automatically detect the run_command on the system to use.
this functionality may be reused in other places within the library, so the create_run_settings function was placed inside smartsim/settings and is now called from the experiment Local tests have been adapted
al-rigazzi
approved these changes
Nov 10, 2021
smartsim/experiment.py
Outdated
| from .control import Controller, Manifest | ||
| from .entity import Ensemble, Model | ||
| from .error import SmartSimError | ||
| from .generation import Generator | ||
| from .utils import get_logger | ||
| from .utils.helpers import colorize, init_default | ||
| from .utils.helpers import colorize, init_default, is_valid_cmd |
There was a problem hiding this comment.
Is is_valid_cmd used? I don't see it in the code
added 2 commits
November 19, 2021 14:23
The default to create_run_settings is "auto", but the case when the user explicitly did not want a run command was not covered. Users can now request that a command be run without a run command by specifying run_command=None in the create_run_settings function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
Experiment.create_run_settingsfunction which is the first step towards better portability of driver scripts between system types.See issue #91 for more details.