Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using shell=True #327

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Avoid using shell=True #327

merged 1 commit into from
Jul 26, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 24, 2023

Remove explicit use of shell=True to avoid potential security issues

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #327 (0e65668) into develop (211268e) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e65668 differs from pull request most recent head c228040. Consider uploading reports for the commit c228040 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #327   +/-   ##
========================================
  Coverage    87.19%   87.19%           
========================================
  Files           59       59           
  Lines         3522     3522           
========================================
  Hits          3071     3071           
  Misses         451      451           

Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this in context, I don't see a good reason why this should have a shell=True.

@ankona ankona merged commit a164b82 into CrayLabs:develop Jul 26, 2023
10 checks passed
@MattToast MattToast added the type: refactor Issues focused on refactoring existing code label Sep 13, 2023
@ankona ankona deleted the oss477 branch April 4, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Issues focused on refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants