Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE Safety #692

Merged
merged 4 commits into from Apr 15, 2024
Merged

NPE Safety #692

merged 4 commits into from Apr 15, 2024

Conversation

TrueDarkLord
Copy link
Contributor

Add the same level of NPE safety to the newest option as the others have.

ryderbelserion and others added 4 commits April 14, 2024 12:16
Signed-off-by: Ryder Belserion <no-reply@ryderbelserion.com>
Signed-off-by: Ryder Belserion <no-reply@ryderbelserion.com>
Add the same level of NPE safety to the newest option.
@ryderbelserion
Copy link
Member

ryderbelserion commented Apr 15, 2024

I raise you, You could even put the crate name in the string.
image

@ryderbelserion ryderbelserion changed the base branch from main to dev April 15, 2024 15:53
@TrueDarkLord
Copy link
Contributor Author

The current method was used to create consistency with the other variables used in the Crate Object construction.
In the end, how the message is handled will have the same effect; to properly inform the user instead of throwing an error that is difficult to understand. Due to this, I will leave any changes to you as they will be based on personal preference instead of functionality.

I believe it would also be beneficial to add annotations to define the nullability of each object as this will help guide future consistency and reduce the likelihood of errors.

@ryderbelserion ryderbelserion merged commit 66275e3 into dev Apr 15, 2024
@ryderbelserion ryderbelserion deleted the NPE-Safety branch April 15, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants