Book Performance

Get itemMeta is a heavy method to use. Reduce the amount it is used for performance.
Crazy-Crew · Mar 23, 2024 · 7c86631 · 7c86631
1 parent 29a3f1b
commit 7c86631
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.../com/badbones69/crazyenchantments/paper/controllers/settings/EnchantmentBookSettings.java b/.../com/badbones69/crazyenchantments/paper/controllers/settings/EnchantmentBookSettings.java
@@ -66,9 +66,11 @@ public boolean hasEnchantment(ItemMeta meta, CEnchantment enchantment) {
      * @return If the book is a CEBook it will return the CEBook object and if not it will return null.
      */
     public CEBook getCEBook(ItemStack book) {
-        if (!book.hasItemMeta() || !book.getItemMeta().getPersistentDataContainer().has(DataKeys.stored_enchantments.getNamespacedKey())) return null;
+        if (!book.hasItemMeta()) return null;
+        ItemMeta meta = book.getItemMeta();
+        if (!meta.getPersistentDataContainer().has(DataKeys.stored_enchantments.getNamespacedKey())) return null;
 
-        EnchantedBook data = this.gson.fromJson(book.getItemMeta().getPersistentDataContainer().get(DataKeys.stored_enchantments.getNamespacedKey(), PersistentDataType.STRING), EnchantedBook.class);
+        EnchantedBook data = this.gson.fromJson(meta.getPersistentDataContainer().get(DataKeys.stored_enchantments.getNamespacedKey(), PersistentDataType.STRING), EnchantedBook.class);
 
         CEnchantment enchantment = null;
         for (CEnchantment enchant : getRegisteredEnchantments()) {