Support Folia

[Euphillya]

This version breaks Spigot and Paper compatibility before 1.20.1

Features :

• Support Folia (in progress)

Fix :

• mcMMO 80cff79 563704b
• Metrics Support Folia

[TrueDarkLord]

Oh epic! I will make sure to check this out tomorrow.

Breaking compatibility with older versions also isn't a problem as we tend to now only support the latest releases of PaperMC. Compatibility with older versions has been broken quite a few times by now.

[Euphillya]

I don't think there is any other incompatibility.

[TrueDarkLord]

All seems to be quite straight forward; just switching over to a different scheduler.
Everything seems to be working as intended based on the quick checks that I did on paper-1.20.4-496.jar as well as on the un-relocated jar.

Just one suggested change and one potential change.

[TrueDarkLord]

For each of the check<enchantName> methods, I would assume that having player.getScheduler().run lower down where the older method was would be better due to it keeping more of the processing off the main thread.

[Euphillya]

Is it good ?

They changed it

[ryderbelserion]

You have unsigned commits blocking the merge.

[Euphillya]

Should I recreate this PR?

[ryderbelserion]

git rebase --exec 'git commit --amend --no-edit -n -S' -i development or use a commit hash like 6313ca1

This rebases everything till development (or any hash) and you don't have to copy paste after every commit.

https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

[ryderbelserion]

git rebase --exec 'git commit --amend --no-edit -n -S' -i development or use a commit hash like 6313ca1

This rebases everything till development (or any hash) and you don't have to copy paste after every commit.

https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

or yeah you can re-create the branch and re-commit then open a new pull request