Dynamic Thread Pool #812
Merged
Dynamic Thread Pool #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NBT-API as it seems to be the only thing needed to fully support the coming changes.
Change over to using a thread pool instead of a single thread in order to make sure that all tasks can be processed. Added a custom checker to re-size the core pool size depending on the amount of tasks in an attempt to reduce the creation of un-needed threads.
|
Changed it to the 1.20.5 branch for the time being, it'll all get merged into main eventually anyway |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to using a thread pool instead of a single thread to ensure all tasks can be processed. Additionally, a custom checker has been added to resize the core pool size based on the number of tasks, aiming to minimize the creation of unnecessary threads.
If the queue is filled with more than ten thousand processes, it will start to throw errors. Since each thread can handle 100+ per second, this should not be a problem. With one to ten players on the server, the queue with one worker thread tends to stay empty. If the queue is more than 1/5th full while using a single thread, another one is added.
Changes: