Solving the single quote bug for both labels and note + selected label in the spinner #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug that is solved in this is mentioned in #66.
This bug was instigated whenever there was a single quote ( ' ) present in the label or a note.
This was because SQLite considers a single quote as an endpoint for a string and that was the reason for it.
And I used continuous single quotes ('') replacing single quotes while adding and displaying which prevents it from crashing now because SQL exempts continuous single quotes.
It was done in all the page adapters.
I also upgraded the feature of the selected spinner of a habit which wasn't done before and it would select the first label rather than the label that is actually selected in the database.