Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the latest code #18

Merged
merged 22 commits into from
Dec 11, 2018
Merged

Update the latest code #18

merged 22 commits into from
Dec 11, 2018

Conversation

CrazyHZM
Copy link
Owner

What is the purpose of the change

Update the latest code

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

lonre and others added 22 commits December 6, 2018 22:37
Just return the class instead of throwing exception.
#2826)

* Simplify the code logic of the method AbstractClusterInvoker#reselect.

* Minor modification for code style.
* create AbstractRouter

* router default method

* router default method

* router default method

* mockinvoker
)

* optimize findConfigedPorts method of ServiceConfig to log only one time when userandom port

* move the log to method putRandomPort
* Improve UT grammer, fix compiler warnings.

* Remove unnecessary braces.
* fix testCustomExecutor

* fix ci
delete unused logic and take the logger out.
@CrazyHZM CrazyHZM merged commit fc59784 into CrazyHZM:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet