LED fix RPi permission check and message #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPi array class in LED module would check with real UID/GID for read/write permission on
/dev/mem
but this will fail for regular users runningsudo
. Addedeffective_ids=True
toos.access
call.Following a failure on this check, the log message suggested giving the user access to
/dev/mem
, which I have since learned is a horrendous security hole and such suggestion has not been removed.