Exclude Individual Entity Properties #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamnichols
reviewed
Aug 5, 2022
This was referenced Aug 5, 2022
liamnichols
reviewed
Aug 5, 2022
Co-authored-by: Liam Nichols <liam.nichols.ln@gmail.com>
liamnichols
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic property exclusions for entities. I really don't know why I overthought this as it's really simple. I provide a warning for when an excluded property in the config does not actually exist in the schema as it's technically incorrect against the schema, but won't break the generation. I don't provide any other warnings or errors for exclusion as that will be caught either at the compilation or the API level by the developer and they manually excluded objects in their config.
I don't provide a warning against renamings+excludes or redundant excludes, which would require validating the exclude list right after parsing and before any generation. I think these are up to the developer to keep clean or we can create a robust config validator to surface these warnings.