Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entities.include #5

Merged
merged 8 commits into from Jan 21, 2022
Merged

Add Entities.include #5

merged 8 commits into from Jan 21, 2022

Conversation

imjn
Copy link
Member

@imjn imjn commented Jan 21, 2022

Hello :)

What

While implementing this plugin into our project, I found that Entities.skip is very hard to maintain.
Therefore, I'd like to implement include which works completely opposite way from skip.

Background

We are currently just replacing hard-coded entities with CreateAPI generated entities, but of course, it is difficult to replace hundreds of entities at once. Therefore, we plan to replace them gradually. In this context, include is much more useful than skip.

Changes

  • Renamed skip to exclude to provide a kind of consistency with include. If you have any other suggestions, please :)
  • Added include
  • Throw error when both of include and exclude have value.

@kean
Copy link
Member

kean commented Jan 21, 2022

Looks great, thanks for the contribution.

I also added a ticket to replace "skip" everywhere #6 as a reminder.

@kean kean merged commit 1f26659 into CreateAPI:main Jan 21, 2022
@imjn imjn deleted the add-include-feature branch January 21, 2022 15:17
@kean
Copy link
Member

kean commented Jan 29, 2022

I also added a ticket to replace "skip" everywhere #6 as a reminder.

Fixed in 0.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants