remove direct use of HTMLCanvasElement #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Can you re-submit without the new minified builds? Happy to merge once that's complete. |
Ok, I have re-push change. |
|
Would love to see this merged and have a new release published to npm! This is currently a blocking issue for me. |
|
Thanks, I can merge this shortly. |
|
Reviewing this: It does change the behaviour. In the current version, the HTML canvas always overrides the one created using In the PR, it will only do it if the Not saying its a bad implementation, but its different, so I am just following up with the author on intent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTMLCanvasElement is interface of canvas element, it should not be used to create element.