Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stitch staggering affected by culling (reposted from #27) #62

Closed
golanlevin opened this issue Jun 26, 2020 · 4 comments
Closed

Stitch staggering affected by culling (reposted from #27) #62

golanlevin opened this issue Jun 26, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@golanlevin
Copy link
Member

Hi @LingDong-
I've closed #27 and opened a new issue that @tatyanade pointed out there:

Staggering gets eliminated at some point when two shapes are culled - visible in lower part of circles on the left - both are parallel hatch with hatch spacing of 2 and second one is spacing of 4

85362403-546e0780-b4ec-11ea-86bf-3cc33f8b6842

@golanlevin golanlevin assigned golanlevin and LingDong- and unassigned golanlevin Jun 26, 2020
@golanlevin golanlevin added the bug Something isn't working label Jun 26, 2020
@golanlevin
Copy link
Member Author

Or is there a way to use beginOptimize() etcetera to address this?

@LingDong-
Copy link
Collaborator

LingDong- commented Jun 26, 2020

Maybe we should recommend using PEmbroiderBooleanGraphics for achieving this effect. The culling happens after the shapes are drawn and doesn't have access to the original parameters, so it's always going to be less perfect

Additionally to achieve the culling the polylines has to be resampled, and the original stitch placement are of course ruined

@golanlevin
Copy link
Member Author

OK, I will try making a demo to compare.

@golanlevin golanlevin assigned golanlevin and unassigned LingDong- Jun 26, 2020
golanlevin added a commit that referenced this issue Jun 27, 2020
@golanlevin
Copy link
Member Author

@LingDong- , it's what you recommended.

Screen Shot 2020-06-26 at 10 53 37 PM

@tatyanade , please study the following test project to see what's going on here:
examples/tests/PEmbroider_culling_stitch_stagger/PEmbroider_culling_stitch_stagger.pde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants