pistachio: marduk: Switch on heartbeat LED #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Ham22
requested changes
Nov 30, 2016
| { | ||
| u32 reg, val; | ||
|
|
||
| /* make GPIO output */ |
There was a problem hiding this comment.
Can you refactor to use a select_* function?
ghost
force-pushed
the
task-45
branch
2 times, most recently
from
692697d
to
24cf58a
Compare
Avinash95
reviewed
Dec 1, 2016
| { | ||
| u32 reg, val; | ||
| reg = PISTACHIO_GPIO + 0x204 + (((mfio) / 16) * 0x24); | ||
| val = 0x10000 | ((output) ? (1) : (0)); |
There was a problem hiding this comment.
can we get rid of ternary operator by directly ORing output ?
There was a problem hiding this comment.
I am leaving as it is to be consistent with the rest of the code.
ghost
force-pushed
the
task-45
branch
2 times, most recently
from
e82437d
to
71acd09
Compare
Ham22
approved these changes
Dec 2, 2016
Avinash95
reviewed
Dec 2, 2016
| u32 reg, val; | ||
|
|
||
| reg = PISTACHIO_GPIO + 0x208 + (((mfio) / 16) * 0x24); | ||
| val = 0x10000 | ((state) ? (1) : (0)); |
There was a problem hiding this comment.
state is already bool, why do we need ternary operator ?
| @@ -103,23 +103,20 @@ static struct pistachio_mfio_reg pistachio_mfio_regs[] = | |||
| {MFIO_89_FUNC_SEL_START, MFIO_89_FUNC_SEL_END}, | |||
| }; | |||
|
|
|||
| static void pistachio_select_gpio(u32 mfio, bool gpio) | |||
| static void pistachio_select_gpio(u32 mfio, bool output) | |||
There was a problem hiding this comment.
instead of pistachio_select_gpio(), can we name it pistachio_configure_gpio() ?
Avinash95
reviewed
Dec 2, 2016
| void mfio_setup_led(void) | ||
| { | ||
| /* make GPIO output */ | ||
| pistachio_select_gpio(76, 1); |
There was a problem hiding this comment.
Can we have macro for this, as GPIO_OUTPUT and GPIO_INPUT
pistachio_select_gpio configures gpio as an input or an output. Inputs are configured not to generate interrupts. Signed-off-by: Francois Berder <francois.berder@imgtec.com>
Signed-off-by: Francois Berder <francois.berder@imgtec.com>
Signed-off-by: Francois Berder <francois.berder@imgtec.com>
ghost
force-pushed
the
task-45
branch
3 times, most recently
from
e28c861
to
9745177
Compare
Signed-off-by: Francois Berder <francois.berder@imgtec.com>
Ham22
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this connects CreatorDev/openwrt#45
Signed-off-by: Francois Berder francois.berder@imgtec.com