Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large modpack rendering issue (re-investigated!) #5419

Closed
vgrynch opened this issue Aug 28, 2023 · 6 comments
Closed

Large modpack rendering issue (re-investigated!) #5419

vgrynch opened this issue Aug 28, 2023 · 6 comments
Labels
type: bug Issue where something isn't working

Comments

@vgrynch
Copy link

vgrynch commented Aug 28, 2023

Describe the Bug

Shortly:
No optifine, no rubidium, no rendering mods, no packet fixers/filters/modfiers.
This simple machine:
image

For large modpack, it fails to render like this:
image

Detailed investigate:
I have spent 2 days trying to find out which mod exactly causes this. It appears none: this is Create mod behavior only. I have tried different approaches:

  • add a set of ~20 mods at a time and see when it starts to fail. It started to fail with completely different mod sets.
  • remove a set of ~20 mods at a time and see when it starts to work correctly. It appears it starts working with completely different mods removed.
    Also tried different versions of Create mod (1.19.2 only).

When using hand crank in the machine above, I observe exceptions in the log:

[22:42:19] [Render thread/ERROR]: Error executing task on Client
java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.block.state.BlockState.m_60734_()" because "p_46606_" is null
	at net.minecraft.world.level.Level.m_6933_(Level.java:198) ~[client-1.19.2-20220805.130853-srg.jar%23607!/:?]
	at net.minecraft.client.multiplayer.ClientLevel.m_233653_(ClientLevel.java:134) ~[client-1.19.2-20220805.130853-srg.jar%23607!/:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_205522_(ClientPacketListener.java:635) ~[client-1.19.2-20220805.130853-srg.jar%23607!/:?]
	at net.minecraft.network.protocol.game.ClientboundSectionBlocksUpdatePacket.m_132992_(ClientboundSectionBlocksUpdatePacket.java:72) ~[client-1.19.2-20220805.130853-srg.jar%23607!/:?]

(The full log with network packets included is attached)

This is OLD issue. It is reported here or there in many places and a common recommendation is find what mod causes it or remove/disable optifine or rubidium. In the majority of cases, none helps (unless remove a significant amount of mods from the modpack.) Here are good examples:

A similar investigation made ~year ago:
image
(https://forums.minecraftforge.net/topic/113399-need-help-tracking-down-an-elusive-npe/)

An example report for a large modpack:
FTBTeam/FTB-Modpack-Issues#3624

Reproduction Steps

  1. Install a server and client with a large Forge modpack (~170-200 mods, sometimes need more)
  2. Create a simple machine like in the description. Create a train contraption and assemble it.
  3. Observe rendering issues when trying to use the machine or disassemble the train. Sometimes it works, sometimes not, depending on the number of modpacks.

Expected Result

No rendering issues appear and no rendering exceptions in the logs.

Screenshots and Videos

No response

Crash Report or Log

https://www.dropbox.com/scl/fi/o6hf9kchkjfacogqeabh8/latest.log?dl=0&rlkey=zd3ynk17d7btpjyyilvfvbm1h

Operating System

Windows 11

Mod Version

0.5.1c

Minecraft Version

1.19.2

Forge Version

43.2.21

Other Mods

Large modpacks

Additional Context

No response

@vgrynch vgrynch added the type: bug Issue where something isn't working label Aug 28, 2023
@vgrynch
Copy link
Author

vgrynch commented Sep 1, 2023

This may be related to https://bugs.mojang.com/browse/MC-258163, I will test it and let you know.

@vgrynch
Copy link
Author

vgrynch commented Sep 1, 2023

No, the block limit fix (https://www.curseforge.com/minecraft/mc-mods/block-limit-fix/files) did not help. Contraption still ends with empty blocks after auto-disassembling.

@vgrynch
Copy link
Author

vgrynch commented Sep 1, 2023

Also, I have noticed that increased load more likely causes it. For example, if add "Chisel and Bits" blocks to the contraption (or some other blocks with large NBT data), it also starts to get some blocks to disappear.

@vgrynch
Copy link
Author

vgrynch commented Sep 1, 2023

Actually, the Block Limit Fix seems involved, because exception logs were changed after adding it. It seems one more fix is required - created issue for that - TropheusJ/block_limit_fix#3

@vgrynch
Copy link
Author

vgrynch commented Sep 6, 2023

This becomes even worse: I discovered that the larger the contraption is, the fewer mods should be in the modpack to make it work without this glitch. I clearly reach the point when the contraption in the images in this ticket work well, while doors from the integrated stronghold mod do not work and break:

Before:

image

after:
image

The same exceptions are in the client-side logs.

@vgrynch
Copy link
Author

vgrynch commented Oct 2, 2023

Completely confirmed this is related to https://bugs.mojang.com/browse/MC-258163. I was able to fix this by re-building block limit fix mod to 1.19.2 version only. The issue can be closed as not Create's issue.

@vgrynch vgrynch closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant