Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor items from Create do not render trims when using Almost Unified or added via NBT data #6213

Open
steve-the-player opened this issue Mar 4, 2024 · 2 comments
Labels
type: bug Issue where something isn't working

Comments

@steve-the-player
Copy link

steve-the-player commented Mar 4, 2024

Describe the Bug

Base Create does not allow backtanks, diving helmets, or diving boots to be trimmed (#6204), but something in my modpack (possibly Almost Unified) allows them to be trimmed. You can also get the same results from editing NBT data. When they are trimmed, the visuals do not update to reflect that. I have tested this both on Forge and the Fabric port.

Reproduction Steps

  1. Install Create
  2. Install Almost Unified (or NBT editor)
  3. (optional) Install a mod/datapack like Create:Trimmed to allow for create materials to be used in trims (polished rose quartz, brass, zinc, xp)
  4. (optional) Install Better Trim Tooltips
  5. Trim a piece of Create armor (or paste the NBT data from trimmed vanilla armor)

Expected Result

armor should render decorative trims

Screenshots and Videos

2024-03-04_13 46 12
2024-03-04_13 46 33
2024-03-04_13 46 29
2024-03-04_13 46 25
2024-03-04_13 46 20

Crash Report or Log

No response

Operating System

tested on both MacOS (Ventura 13.5.1) and Windows 11

Mod Version

0.5.1d

Minecraft Version

1.20.1

Forge Version

latest. Fabric version was 0.15.6

Other Mods

I was using a dev/testing version of Delighted! when I first discovered the discrepancy, but that shouldn't be relevant

Additional Context

No response

@steve-the-player steve-the-player added the type: bug Issue where something isn't working label Mar 4, 2024
@DefomCode
Copy link

will this mistake be solved at all? so much time has passed and there is not even an answer. I don't want my gaming experience to turn into a choice: to be stylish or to be completely protected and have an ugly appearance due to the fact that only trousers can visually improve

@IThundxr
Copy link
Collaborator

will this mistake be solved at all? so much time has passed and there is not even an answer. I don't want my gaming experience to turn into a choice: to be stylish or to be completely protected and have an ugly appearance due to the fact that only trousers can visually improve

there are over 1.3k open issues, all of which need to be looked at and triaged as necessary, please be patient, i'll get to this eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants