Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the creation of the parameter inheritance tree #3

Closed
wants to merge 1 commit into from

Conversation

jdreesen
Copy link
Contributor

@jdreesen jdreesen commented Oct 25, 2023

Description

We should use the variable that holds the method name instead of the parameter name to get the method from the reflection class.

Motivation and context

It's late, and I'm a bit tired, but I was just browsing the code and if I'm not mistaken, the wrong variable was used when getting the method while determining the parameter inheritance tree.

How has this been tested?

I didn't.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@Crell
Copy link
Owner

Crell commented Oct 27, 2023

This will absolutely need a corresponding test. Visually I see what you mean, but the code certainly seems to have been working so far. That the unit tests pass suggests there's a gap in test coverage, which we need to close.

@Crell
Copy link
Owner

Crell commented Oct 28, 2023

Heh, turns out, parameter inheritance was completely untested. 🙃

I've fixed that in my "prep for 1.0.0" branch, and corrected this typo, too. Thanks for the catch.

@Crell Crell closed this Oct 28, 2023
@Crell Crell mentioned this pull request Oct 28, 2023
Merged
@jdreesen jdreesen deleted the patch-1 branch October 29, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants