-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetInputSourcePath #80
Comments
Thanks a lot, much appreciated. eg.
|
This is a very minor detail, but i think it would be better to have a more consistent naming scheme, like either: |
Reason is, AviSynth is a function, VapourSynth is a variable. It doesn't make sense to have a verb in a variable name. The |
Fair enough.
Not quite sure i get what you mean by existing convention here, but many AviSynth-functions i know of, have names that lack the verb entirely. (e.g. So based on the |
So without reading document, will user be able to tell if this sets time or gets time in specified format? Will user know There is a good reason most coding style guides recommend having verb + subject form as function name for clarity. Like I said, the only reason Since |
I think in the context of AviSynth-scripting, the purpose of 'GetString'-type functions can be inferred, since most 'SetString'-type functions never need to be accessed from the scripting-interface, but i get why it would be bad for a project that needs to set time or spoof version info.
I suspect it was done in part for the sake of brevity and in part to create more of a separation between backend-code and user-side-scripting, but i get now what you mean.
Ok, fair enough. |
Could we please have a _env->AddFunction("GetInputSourcePath") so we can tell what video is playing so we can make our own per-file/folder scripting rules. i.e same as API_MSG_GET_INPUT_SOURCE_PATH but accessible inside avs script.
The text was updated successfully, but these errors were encountered: