Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example mod is broken #6

Closed
StellarWind22 opened this issue Oct 18, 2021 · 4 comments
Closed

Example mod is broken #6

StellarWind22 opened this issue Oct 18, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@StellarWind22
Copy link
Owner

The actual example mod is broken and doesn't even compile. In some places it uses "examplemod" as modid in others it uses "modid". This is pretty much just a reminder to myself to clean up the examplemod.
@StellarWind22 StellarWind22 added the bug Something isn't working label Oct 18, 2021
@StellarWind22
Copy link
Owner Author

I noticed this because after I merged the changes a couple of minutes later I got an email saying that the automatic build test with GitHub failed to build on all platforms.

@CringeStar
Copy link
Contributor

yeah i might have missed a few "modid" spaces, my bad

@CringeStar
Copy link
Contributor

i found the problem, in 1.4.1 we moved renderBanner(), but I didn't change the method in RendererMixin. Im about to open a pr. Im going to also fix the "modid" and "examplemod" conflictions

@CringeStar CringeStar mentioned this issue Oct 18, 2021
Merged
@CringeStar
Copy link
Contributor

Should be fixed in the new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StellarWind22 @CringeStar