Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Deactivate #387

Closed
arroyoDev opened this issue Sep 21, 2017 · 3 comments
Closed

User Deactivate #387

arroyoDev opened this issue Sep 21, 2017 · 3 comments
Labels
admin enhancement good impact
Projects
9-21 Solar Winds Hackathon
Milestone
Admin User Manage...

Comments

@arroyoDev
Copy link
Member

The system currently has no way to de-activate a user. We need to have that setting that prevents access and hides them form lists everywhere.
@arroyoDev arroyoDev added this to the Admin User Management milestone Sep 21, 2017
This was referenced Sep 21, 2017
Closed
Closed
@astashov
Copy link
Contributor

I'll try to take this

@astashov
Copy link
Contributor

Approach: we could add is_disabled boolean field to users db, false by default. Then, we add a default_scope, which is is_active: false to User model. It's usually an antipattern, but in this case since we'll have to use it like in 90% of cases, should be okay.

Then, we'll exclude that default scope in /admin/users, and add a field - checkbox is_disabled to the edit user form.

What do you think?

@tsanders
Copy link
Collaborator

Yes, that should definitely work.

astashov added a commit to astashov/crisiscleanup that referenced this issue Sep 22, 2017
@astashov
Add a way to disable a user
fa0eefd 
Ticket: CrisisCleanup#387

* Added `is_disabled` boolean field to `users` table, `false` by default.
* Added a `default_scope`, which is `is_active: false` to `User` model.
  It's usually an antipattern, but in this case since we'll have to use
  it like in 95% of cases, it should be okay.
* Excluded that default scope in `Admin::UsersController`'s actions
* Added the column `is_disabled` to the User's databable in `datatable.js`
  field, and also the checkbox `is_disabled` to the edit user form.

Testing:
* I've clicked through the site, found those places where we have users
list:

* /admin/users
* /worker/my-organization
* /worker/incident/:iid/organizations/:oid

I think that's it. Everywhere there the disabled user was not listed
Also
* Made sure after disabling you can't log in anymore.
* You still can send an invitation to signup to the same email, that was
  disabled, but if you try to signup, it fails silently. Would be nice
  to improve error messaging there, but for now it's out of scope of
  this PR.
* You still can see an invitation in `/worker/my-organization`, even if
  user was disabled. I guess that's fine, what do you think?

Other that that, it seems to be working, unless I missed something. :)
@astashov astashov mentioned this issue Sep 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin enhancement good impact
Projects
No open projects
9-21 Solar Winds Hackathon
Awaiting triage
Milestone
Admin User Management
Development

No branches or pull requests
4 participants
@astashov @tsanders @arroyoDev @aarontitus