Fixing js minimization and removing sourcemaps in production #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfairchild
commented
Jan 19, 2021
gulpfile.babel.js
Outdated
| )); | ||
|
|
||
| // Scan your HTML for assets & optimize them | ||
| gulp.task('html', gulp.series(() => { | ||
| return gulp.src('app/**/*.html') | ||
| .pipe($.useref({ | ||
| searchPath: '{.tmp,app}', | ||
| noAssets: true | ||
| noAssets: false |
There was a problem hiding this comment.
i don't think this is doing anything for us.
jfairchild
commented
Jan 19, 2021
| .pipe($.size({ title: 'scripts' })) | ||
| .pipe($.sourcemaps.write('.')) |
There was a problem hiding this comment.
not sure why this was running twice, but we don't need it for production deploys.
wdoug
reviewed
Mar 23, 2021
wdoug
reviewed
Mar 23, 2021
| --- | ||
|
|
||
| 1. Use the API Gateway endpoint to get the lastest value. |
There was a problem hiding this comment.
Haha, I like lastest as a word
wdoug
reviewed
Mar 23, 2021
wdoug
reviewed
Mar 23, 2021
| './app/scripts/sections/*.js', | ||
| './app/scripts/main.js' | ||
| ]) | ||
| ], {base: './app/scripts/'}) |
There was a problem hiding this comment.
I'm not familiar with some of this specific gulp configuration, but running it locally it seems like it works 🤷
There was a problem hiding this comment.
I had updated gulp in a previous PR. There was an issue with changing the relative paths of the js files if the base was not provided.
jfairchild
commented
Mar 23, 2021
| @@ -18,7 +18,7 @@ | |||
| }, | |||
| conversations: { | |||
| // count must be an integer | |||
| fallbackConversationCount: 4873330, | |||
| fallbackConversationCount: 5680775, | |||
wdoug
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.