Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.html #91

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Update index.html #91

merged 2 commits into from
Sep 15, 2020

Conversation

esmith-CTL
Copy link
Contributor

Change the message count text to now reflect the conversations count changes

@esmith-CTL
Update index.html
9afa474 
Change the message count text to now reflect the conversations count changes
jfairchild
jfairchild reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jfairchild jfairchild left a comment •
edited by esmith-CTL
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the following:

  • Rename message-count.js to conversation-count.js

  • Add a fallback value for the conversation count

  • Add the new API Gateway endpoint /conversations

  • Update CSS usages of message

jfairchild
jfairchild approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jfairchild jfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@esmith-CTL esmith-CTL merged commit 65e8379 into v2 Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfairchild jfairchild jfairchild approved these changes

@shaynemartin91 shaynemartin91 Awaiting requested review from shaynemartin91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esmith-CTL @jfairchild