Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plot_genome_vs_cm.R #65

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

jeekinlau
Copy link

please check if my code works but it should produce this plot
image

@jeekinlau jeekinlau closed this Apr 25, 2023
@jeekinlau jeekinlau reopened this Apr 25, 2023
@jeekinlau
Copy link
Author

function is ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.77 ⚠️

Comparison is base (4539d42) 57.45% compared to head (6cca1c4) 56.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   57.45%   56.68%   -0.77%     
==========================================
  Files          58       59       +1     
  Lines        7422     7365      -57     
==========================================
- Hits         4264     4175      -89     
- Misses       3158     3190      +32     
Impacted Files Coverage Δ
R/plot_genome_vs_cm.R 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cristianetaniguti
Copy link
Owner

Issue #66

Copy link
Owner

@Cristianetaniguti Cristianetaniguti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • OneMap has the functions kosambi and haldane already, you can use them instead of the imf_h and imf_k
  • Add a line to check if the input object is a list of sequences and provide an error if not

@jeekinlau
Copy link
Author

fixed above mentions

Copy link
Owner

@Cristianetaniguti Cristianetaniguti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close issue #66

@Cristianetaniguti Cristianetaniguti merged commit 522637a into Cristianetaniguti:main Apr 26, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants